feat: add support for schema keywords#2162
Open
cowboy-bebug wants to merge 6 commits intooapi-codegen:mainfrom
Open
feat: add support for schema keywords#2162cowboy-bebug wants to merge 6 commits intooapi-codegen:mainfrom
cowboy-bebug wants to merge 6 commits intooapi-codegen:mainfrom
Conversation
Author
|
Hi @jamietanna, just a quick ping on this PR. I’ve been using this locally for a few weeks and it significantly simplifies marrying request validation with the spec file. I realized this wasn't in the issues list yet, but it feels like a quality of life improvement that would benefit anyone manually adding min/max constants in application. I've made sure to include tests and documentation to keep the maintenance burden as low as possible for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
I use the tool extensively at work and thought it'd be really great to generate some
constsbased on the JSON schema keywords.This PR adds features to handle the keywords such as
minimum,maximum, etc.:as constants:
I didn't find any relevant / related issues. Let me know if this is something valuable to you guys as well 🙏