MAINT: Replace %-formatting with f-strings in numpy/_core (UP031)#30790
Open
Noxaster wants to merge 3 commits intonumpy:mainfrom
Open
MAINT: Replace %-formatting with f-strings in numpy/_core (UP031)#30790Noxaster wants to merge 3 commits intonumpy:mainfrom
Noxaster wants to merge 3 commits intonumpy:mainfrom
Conversation
6 tasks
51e25f0 to
7c44b65
Compare
rkern
reviewed
Feb 6, 2026
rkern
approved these changes
Feb 6, 2026
Member
rkern
left a comment
There was a problem hiding this comment.
I think these look good to me. I'd prefer one more pair of eyes on these before committing, though, because this is very detail-oriented.
Good catch on turning the itemsize / 4 into an itemsize // 4 because of the implicit truncation of %d. That one was non-obvious. I think all the other %ds that you dropped for plain {} should be fine.
Co-authored-by: Robert Kern <robert.kern@gmail.com>
jorenham
reviewed
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #30785