Add yarn install#1612
Add yarn install#1612LuckyPigeon wants to merge 6 commits intonodegit:masterfrom LuckyPigeon:preinstall-alternative
Conversation
|
related to #1593 |
implausible
left a comment
There was a problem hiding this comment.
Thanks for your help! Would you please fix the indentation in these in your promise methods and consider adjusting the flow of your promise chain as I've suggested in my review?
|
@implausible I've seen the change requested. I not entirely understand what your "fix the indentation" means, could you explain it more precisely? |
|
@implausible Updated |
|
Hrmm.. So upon further review of this code, I noticed that the current patch is proposing to run If you follow the code, we perform I believe that yarn's behavior will mirror that of I think the patch that we're actually looking for looks like this: Can you confirm this solves your issue? |
|
Closed in favor of #1644 |
No description provided.