Fix default parameters to batch scoring pipeline + doc fixes#310
Merged
Fix default parameters to batch scoring pipeline + doc fixes#310
Conversation
jitghosh
approved these changes
Jul 10, 2020
Contributor
jitghosh
left a comment
There was a problem hiding this comment.
Looks good to me. But should we also consider changing the docs to reflect that invoking the pipeline now requires that a model name and version be always passed to it ?
|
Should address #316. |
Contributor
Author
Contributor
Author
|
@cmayomsft I've also included some small doc fixes to resolve some of the issues with the getting started page. Merging this - please reopen those issues if you find that we need more changes here. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the default model name/version inputs, since this will cause an issue if they are not set in the environment variables. Instead, we pass model name/version when we run the batch scoring pipeline.