Merged
Conversation
Recently the step to get the model version had a name associated with the step. We need to also update the references in future step to use the step name as a prefix. This resulted in the MODEL_VERSION variable causing failures in each CD deployment step. This did not show up in CI because the MODEL_VERSION var is hard coded in the variable group. We should also remove that.
j-so
approved these changes
Jul 3, 2020
Contributor
|
Sounds like there's some followup work needed to fully clean this up. Feel free to make a new issue and assign to me if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the template to get the model version had a name associated with the step that sets the variable. We need to also update the variable references in future steps to use the template step name as a prefix. This resulted in the MODEL_VERSION variable causing failures in each CD deployment step since it was not set.
This did not show up in CI because the MODEL_VERSION var is hard coded in the variable group. We should also remove that.