fix AxisLabel not picking up fontsize from set_ylabel in axisartist#31155
Open
Mr-Neutr0n wants to merge 1 commit intomatplotlib:mainfrom
Open
fix AxisLabel not picking up fontsize from set_ylabel in axisartist#31155Mr-Neutr0n wants to merge 1 commit intomatplotlib:mainfrom
Mr-Neutr0n wants to merge 1 commit intomatplotlib:mainfrom
Conversation
ax.set_ylabel('text', fontsize=20) had no effect when using
host_subplot with axisartist.Axes because AxisLabel only copied
the text string and color from the underlying axis label, but
not fontsize. Added get_fontsize/set_fontsize overrides so that
AxisLabel inherits fontsize from the ref artist by default, while
still allowing explicit overrides via label.set_fontsize().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28124.
When using
host_subplot(or anyaxisartist.Axes), callingax.set_ylabel('text', fontsize=20)sets the fontsize on the underlyingyaxis.label, but theAxisLabelin axis_artist never picks it up — it only copies the text string and color from the ref artist. So the label renders at the default size regardless of what you pass toset_ylabel.The fix adds
get_fontsize/set_fontsizeoverrides toAxisLabelthat inherit fontsize from the ref artist by default (similar to howget_coloralready works viaAttributeCopier). If you set fontsize directly on theAxisLabelitself, the override is respected.