MAINT: add AI disclosure to pr template#31124
MAINT: add AI disclosure to pr template#31124story645 wants to merge 2 commits intomatplotlib:mainfrom
Conversation
|
Is this instead of #31043, or in addition? |
In addition - we want all contributors to disclose AI and we want to reassure new contributors it's so we can give 'em good feedback (which is why I didn't put it here) Probably should have just added to that PR but was thinking of them as separate discussions/tasks. |
f62c7d6 to
585373d
Compare
rcomer
left a comment
There was a problem hiding this comment.
Does this count as docs, or do we need two approvals?
🤷♀️ I'm fine w/ more than one as it's kinda an implicit policy change. |
timhoffm
left a comment
There was a problem hiding this comment.
Good as a starting point. It's still a bit vauge:
-
"used AI in writing this PR": Does this mean the code or the PR description or both? Do we need to be more explicit?
-
"please describe how" also leaves room for interpretation and may be difficult to answer for someone who is serious about it. Likely we only want to know "for getting ideas" / "for writing the code" / "for rewording the PR message" / "I promted AI to solve the problem" / "I told an agent to find and fix FOSS issues". But one could answer much more detailed.
As a minimal improvement maybe "please briefly describe" how.
Overall, I think we need to gradually improve on the topic.
it's purposely broad - I wanna see what responses we get before fine tuning, and also we do care about both.
Again trying to leave space for openness - we'd rather someone tell us about AI use we don't care about (research) than not tell us about AI we do. |
585373d to
5ca3290
Compare
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| ## AI Disclosure | ||
| <!-- If you used AI in writing this PR, please briefly describe how. | ||
| Please review our policy at |
There was a problem hiding this comment.
Should the verb rather be read or follow or ...? "Review" sounds a bit like the user should give feedback on the policy. It may be technical correct but in the context of PRs "review" has a default connotation. At least I Asia non-native speaker have been stumbling over this.
There was a problem hiding this comment.
I meant it more like how you review material for an exam, but changed it to read.
5ca3290 to
a710e4a
Compare
|
@rcomer added your wording from #30848 (comment) to the second commit |
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
b990b8f to
856e477
Compare
PR summary
Jumping off the discussion in #30848 and my wanting to add a disclosure to a PR to model the behavior I want to see, added a section on AI disclosure cause that seemed the easiest. Going simple here in the spirit of #30848 (comment) and we can always add more later.
PR checklist