Port requirements to PEP735 by QuLogic · Pull Request #29281 · matplotlib/matplotlib

QuLogic · 2024-12-11T10:33:32Z

PR summary

PEP735 introduces the concept of "Dependency Groups"; these essentially replace our use of various requirements.txt files.

~~NOTE: This is waiting for pip to actually implement Dependency Groups: pypa/pip#12963 We may or may not wish to wait for that to bake a bit even after it's been implemented as well.~~

PR checklist

[n/a] "closes #0000" is in the body of the PR description to link the related issue
new and changed code is tested
[n/a] Plotting related features are demonstrated in an example
[n/a] New Features and API Changes are noted with a directive and release note
Documentation complies with general and docstring guidelines

QuLogic · 2024-12-11T11:01:56Z

Note, tox does support this already, so the stubtest job is the only one (using dependencies) that does work right now.

WeatherGod

I was curious about this new PEP, so I took a look through the changes. I think this would be a really neat feature when pip implements it. I know this is just a draft, but I figured I can point out a couple things I noticed, and I had a couple of questions, too.

.github/workflows/cygwin.yml

WeatherGod · 2024-12-11T12:29:51Z

azure-pipelines.yml

              python -m pip install --upgrade pip
-              python -m pip install --upgrade -r requirements/dev/build-requirements.txt
-              python -m pip install -r requirements/testing/all.txt -r requirements/testing/extra.txt
+              python -m pip install --group build --group test --group test-extra


We'll have to see if it matters whether or not we were upgrading certain dependencies or not. I suspect not.

pyproject.toml

WeatherGod · 2024-12-11T12:50:20Z

pyproject.toml

+
+# Extra pip requirements for the Python 3.10+ builds
+test-extra = [
+    "--prefer-binary",


Will command-line arguments and sys.platform references work in this PEP? It isn't entirely clear to me.

Ah, the command-line argument probably won't, but we'll have to see how the pip implementation ends up. The sys.platform should work as these are standard dependency specifiers.

I learned something new! Neat!

So unfortunately, we can't keep --prefer-binary here, so I've moved it to the CI invocation.

WeatherGod · 2024-12-11T12:57:55Z

.github/workflows/reviewdog.yml


      - name: Install mypy
-        run: pip3 install -r requirements/testing/mypy.txt -r requirements/testing/all.txt
+        run: pip3 install --group typing


does this also need group "test"?

I'm hoping not, so we can reduce the install set.

WeatherGod · 2024-12-11T13:05:38Z

pyproject.toml

+#
+# You will first need a matching Matplotlib installation
+# e.g (from the Matplotlib root directory)
+#     pip install --no-build-isolation --editable .[dev]


Is the .[dev] correct? Or should it be just .?

The [dev] is an extra, not a dependency group. It was intended to cover both build and runtime dependencies. It didn't really work though, as pip installed . before its dependencies, so you couldn't get the build ones early enough. Based on the other implementations, dependency groups should be strictly better, since they should install before ., but we'll have to see how it's finally implemented. I should probably rewrite this section a bit once that's finalized.

Oh, I see. I'm not used to seeing an extra be specified against a directory, so I thought it was a typo. And, yeah, extras wouldn't work for installing dependencies.

No more .[dev] now.

QuLogic · 2025-04-22T07:05:43Z

I rebased and fixed the comments. pip doesn't yet support this, but pypa/pip#13065 is scheduled for 25.1 next weekend.

dstansby

This is also going to require pip >= 25.1 for anyone developing Matplotlib - that should at least go in some sort of release note/changelog entry, and be noted in the development setup docs.

.github/workflows/tests.yml

azure-pipelines.yml

dstansby · 2025-05-18T09:32:43Z

pyproject.toml

+    {include-group = "doc"},
+    {include-group = "test"},
+    {include-group = "test-extra"},
+    "ruff",


pre-commit should be added here, and perhaps ruff dropped since running pre-commit runs ruff.

dstansby · 2025-05-18T09:34:59Z

pyproject.toml

+    "types-python-dateutil",
+    "types-psutil",
+    "sphinx",
+    {include-group = "build"},


Given the doc and test groups dont' depend on build, I don't think typing should either, and the build group can be additionally specified during the CI install stage.

QuLogic · 2025-05-28T21:45:26Z

Added a few notes for the pip 25.1 requirement.

scottshambaugh · 2025-12-31T21:53:03Z

Coming over from #30877, this branch works for a modified uv workflow:

uv venv .venv

# Activate the environment (NOT optional)
source .venv/bin/activate  # Linux/macOS
# or: .venv\Scripts\activate  # Windows

# Install dev dependencies
uv pip install --group dev

# Install matplotlib in editable mode
uv pip install --no-build-isolation --group dev --editable .

# Verify installation
python -c "import matplotlib; print(matplotlib.__file__)"

However, solving dependencies using a strict solver that tries to make a lock file (this includes uv sync or using uv run for anything) is running into repeated issues and dependency conflicts with the "test-minver" group, which go away if that group is removed. I haven't tried pixi, but I expect that this is going to happen with any tool making a lock file that tries to resolve all the dependencies in the base pyproject.toml.

Could we split that group off into its own subproject? Eg something like:

matplotlib/
├── pyproject.toml
└── requirements/
    └── test-minver/
        └── pyproject.toml

requirements/minver-test/pyproject.toml:

[project]
name = "matplotlib-test-minver"
version = "0.0.0"
requires-python = ">=3.11,<3.12"
dependencies = [
    "contourpy==1.0.1",
    "cycler==0.10",
    "fonttools==4.22.0",
    "importlib-resources==3.2.0",
    "kiwisolver==1.3.2",
    "meson-python==0.13.1",
    "meson==1.1.0",
    "numpy==1.25.0",
    "packaging==20.0",
    "pillow==9.0.1",
    "pyparsing==3.0.0",
    "pytest==7.0.0",
    "python-dateutil==2.7",
    "ipython==7.29.0",
    "ipykernel==5.5.6",
    "matplotlib-inline<0.1.7",
]

QuLogic added the status: upstream fix required label Dec 11, 2024

QuLogic added this to the future releases milestone Dec 11, 2024

github-actions bot added CI: Run cygwin Run cygwin tests on a PR Documentation: devdocs files in doc/devel labels Dec 11, 2024

QuLogic force-pushed the pep735 branch from 559f825 to f875002 Compare December 11, 2024 10:57

WeatherGod reviewed Dec 11, 2024

View reviewed changes

github-actions bot added the status: needs rebase label Dec 23, 2024

QuLogic mentioned this pull request Mar 18, 2025

[Bug]: Can't find pybind11 headers when building from source #29741

Closed

QuLogic force-pushed the pep735 branch 2 times, most recently from 0b93f55 to 8ef2f01 Compare April 22, 2025 06:58

github-actions bot removed the status: needs rebase label Apr 22, 2025

QuLogic force-pushed the pep735 branch 3 times, most recently from 5803913 to 6770028 Compare May 1, 2025 09:39

QuLogic marked this pull request as ready for review May 1, 2025 09:39

github-actions bot added the status: needs rebase label May 10, 2025

dstansby reviewed May 18, 2025

View reviewed changes

QuLogic force-pushed the pep735 branch from 6770028 to 35791e0 Compare May 28, 2025 20:39

github-actions bot removed the status: needs rebase label May 28, 2025

QuLogic force-pushed the pep735 branch from 35791e0 to 45b5275 Compare May 28, 2025 21:44

QuLogic removed the status: upstream fix required label May 28, 2025

QuLogic modified the milestones: future releases, v3.11.0 May 28, 2025

QuLogic force-pushed the pep735 branch 2 times, most recently from a27e0ec to c0e0bce Compare June 17, 2025 22:21

QuLogic force-pushed the pep735 branch from c0e0bce to bca05a8 Compare July 2, 2025 20:48

github-actions bot added the status: needs rebase label Jul 24, 2025

QuLogic force-pushed the pep735 branch from bca05a8 to b099a5d Compare October 23, 2025 01:14

github-actions bot removed the status: needs rebase label Oct 23, 2025

Port requirements to PEP735

a8637cf

QuLogic force-pushed the pep735 branch from b099a5d to a8637cf Compare October 29, 2025 08:04

timhoffm mentioned this pull request Dec 30, 2025

[DOC] [BLD] Building / developing matplotlib with uv #30877

Open

Uh oh!

Conversation

QuLogic commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary

PR checklist

Uh oh!

QuLogic commented Dec 11, 2024

Uh oh!

WeatherGod left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuLogic commented Apr 22, 2025

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuLogic commented May 28, 2025

Uh oh!

scottshambaugh commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

QuLogic commented Dec 11, 2024 •

edited

Loading

scottshambaugh commented Dec 31, 2025 •

edited

Loading