Skip to content

Lambda: refactor tagging#13770

Open
bentsku wants to merge 1 commit intomainfrom
rgta-lambda
Open

Lambda: refactor tagging#13770
bentsku wants to merge 1 commit intomainfrom
rgta-lambda

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Feb 13, 2026 •
edited
Loading

Motivation

This PR refactors Tagging in Lambda to support its integration with RGTA.

The only functional difference is that we are now properly cleaning up the tags when deleting a resource, where before they would stay in the store.

Changes

  • refactor store access and tagging functionality to be even more decoupled (splitting validation from store access)

Tests

Related

@bentsku bentsku added this to the 4.14 milestone Feb 13, 2026
@bentsku bentsku self-assigned this Feb 13, 2026
@bentsku bentsku added aws:lambda AWS Lambda semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 13, 2026
@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 111 tests  ±0   21 249 ✅ ±0   6m 20s ⏱️ -7s
     1 suites ±0    1 862 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit df4285c. ± Comparison against base commit 8554f9a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 58s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit df4285c. ± Comparison against base commit 8554f9a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 59m 46s ⏱️
3 803 tests 3 565 ✅ 238 💤 0 ❌
3 809 runs  3 565 ✅ 244 💤 0 ❌

Results for commit df4285c.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 34m 35s ⏱️ - 26m 3s
3 779 tests  - 1 436  3 537 ✅  - 1 326  242 💤  - 110  0 ❌ ±0 
3 781 runs   - 1 436  3 537 ✅  - 1 326  244 💤  - 110  0 ❌ ±0 

Results for commit df4285c. ± Comparison against base commit 8554f9a.

This pull request removes 1436 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@bentsku bentsku marked this pull request as ready for review February 13, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@bentsku bentsku

Labels

aws:lambda AWS Lambda docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

1 participant

@bentsku