Skip to content

CFN: add separate methods for tagging change set and create set#13765

Draft
k-a-il wants to merge 2 commits intomainfrom
flc-278-rgta-cloudformation
Draft

CFN: add separate methods for tagging change set and create set#13765
k-a-il wants to merge 2 commits intomainfrom
flc-278-rgta-cloudformation

Conversation

@k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Feb 13, 2026 •
edited
Loading

Motivation

This PR refactors the existing tagging logic by moving it into dedicated methods within the CloudFormation V2 Provider, making them overridable in the Pro version. These dedicated methods are also incorporated into the operations for creating and deleting change sets and stacks.

In the Pro version, these methods will be overridden to integrate CloudFormation V2 with the new ResourceGroupsTagging plugin, enabling CloudFormation resources to be tagged and allowing tags to be retrieved through the Resource Groups Tagging service.

Changes

  • Moves tagging logic into separate methods to enable their overriding in pro version
  • Integrates the methods introduced above into operations related to change sets and stack functionality in CloudFormation

Tests

Related

FLC-278

@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 111 tests  ±0   21 249 ✅ ±0   6m 26s ⏱️ -1s
     1 suites ±0    1 862 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit b29dfee. ± Comparison against base commit ff1d403.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit b29dfee. ± Comparison against base commit ff1d403.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   40m 54s ⏱️ - 1h 21m 17s
596 tests  - 4 618  372 ✅  - 4 490  113 💤  - 239  111 ❌ +111 
598 runs   - 4 618  372 ✅  - 4 490  115 💤  - 239  111 ❌ +111 

For more details on these failures, see this check.

Results for commit b29dfee. ± Comparison against base commit ff1d403.

This pull request removes 4618 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   45m 32s ⏱️
620 tests 397 ✅ 112 💤 111 ❌
626 runs  397 ✅ 118 💤 111 ❌

For more details on these failures, see this check.

Results for commit b29dfee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026 •
edited
Loading

Test Results - Alternative Providers

595 tests   328 ✅  17m 59s ⏱️
  1 suites  267 💤
  1 files      0 ❌

Results for commit b29dfee.

♻️ This comment has been updated with latest results.

@k-a-il k-a-il self-assigned this Feb 13, 2026
@k-a-il k-a-il requested a review from aidehn February 13, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidehn aidehn Awaiting requested review from aidehn

@simonrw simonrw Awaiting requested review from simonrw simonrw will be requested when the pull request is marked ready for review simonrw is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@k-a-il k-a-il

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@k-a-il