Skip to content

Fix hardcoded AWS user#13685

Draft
joe4dev wants to merge 4 commits intomainfrom
fix-hardcoded-aws-user
Draft

Fix hardcoded AWS user#13685
joe4dev wants to merge 4 commits intomainfrom
fix-hardcoded-aws-user

Conversation

@joe4dev
Copy link
Member

@joe4dev joe4dev commented Feb 3, 2026

Motivation

Snapshot re-validation with another IAM user (e.g., used for AWS preview access) causes a user mismatch. We can solve this dynamically as suggested in this PR review https://github.com/localstack/localstack-pro/pull/5668#discussion_r2565243420

Use cases:

  • We need to create and share a new AWS user for AWS parity testing and cannot choose user/localstack-testing (e.g., specific allow-listed AWS accounts)
  • Some developers might use a different name for the AWS user causing flakiness in our parity testing approach

Changes

  • Add global snapshot transformer for AWS user called :<user>
    • Alternative names could be :<user-role>, or :<aws-user-role
    • This transformer only applies in the ARN context, hence reducing potential false positive with other <USER> transformers used for example for database authentication
  • Add AWS user fixture -> removed in favor of global snapshot transformer
  • Reduce hardcoded user duplication in Lambda code

Related

Fixes DRG-447

@joe4dev joe4dev added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 20s ⏱️ -10s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 9a0933c. ± Comparison against base commit 55611d1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9a0933c. ± Comparison against base commit 55611d1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 36m 41s ⏱️
5 220 tests 4 825 ✅ 345 💤 50 ❌
5 226 runs  4 825 ✅ 351 💤 50 ❌

For more details on these failures, see this check.

Results for commit 9a0933c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 59m 36s ⏱️ + 1m 26s
5 196 tests ±0  4 795 ✅  - 50  351 💤 ±0  50 ❌ +50 
5 198 runs  ±0  4 795 ✅  - 50  353 💤 ±0  50 ❌ +50 

For more details on these failures, see this check.

Results for commit 9a0933c. ± Comparison against base commit 55611d1.

♻️ This comment has been updated with latest results.

@joe4dev joe4dev marked this pull request as ready for review February 3, 2026 17:17
@joe4dev joe4dev marked this pull request as draft February 4, 2026 12:27
@joe4dev joe4dev force-pushed the fix-hardcoded-aws-user branch from cae716b to 9a0933c Compare February 6, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant