Regression: Add DbiFlags#MDB_UNSIGNEDKEY to allow to compare byte array, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0#237
Merged
bp-alex merged 1 commit intolmdbjava:masterfrom Feb 16, 2025
cdprete:fix/unsigned-compare
Merged
Regression: Add DbiFlags#MDB_UNSIGNEDKEY to allow to compare byte array, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0#237bp-alex merged 1 commit intolmdbjava:masterfrom cdprete:fix/unsigned-compare
bp-alex merged 1 commit intolmdbjava:masterfrom
cdprete:fix/unsigned-compare
Conversation
This was referenced Mar 6, 2024
Contributor
Author
|
@benalexau A test for this was done in #230 (comment) |
…ay, ByteBuffer and DirectBuffer keys as unsigned like in versions prior to 0.9.0
Collaborator
|
This PR will need the changes to the github actions workflow file |
Contributor
Author
|
I can pull such changes in without any issue once they get merged.
But, I'm honestly starting to doubt if the project is still maintained in
the first place.
Il mar 4 feb 2025, 14:11 at055612 ***@***.***> ha scritto:
… This PR will need the changes to the github actions workflow file
maven.yml as seen in here
https://github.com/lmdbjava/lmdbjava/pull/235/files. The old v3 actions
will fail the CI build.
—
Reply to this email directly, view it on GitHub
<#237 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAZGWEYULCGS5PLW6T3LGL2OC37XAVCNFSM6AAAAABWORHLZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZTHA3DEMBTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
I've contacted the maintainer (@benalexau) in the hope that the outstanding PRs can be addressed, merged and released. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228 and #230.
I was not able to run the tests locally on Windows (I'm getting a
NoClassDefFoundErrorkind of everywhere), so I hope I didn't break any.