Define manifest attribute Automatic-Module-Name#213
Merged
bp-alex merged 1 commit intolmdbjava:masterfrom Mar 9, 2023
pedrolamarao:automatic-module
Merged
Define manifest attribute Automatic-Module-Name#213bp-alex merged 1 commit intolmdbjava:masterfrom pedrolamarao:automatic-module
bp-alex merged 1 commit intolmdbjava:masterfrom
pedrolamarao:automatic-module
Conversation
Contributor
Author
Member
|
Thanks @pedrolamarao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change defines the manifest attribute
Automatic-Module-Name, transforming the JAR into an automatic module with module nameorg.lmdbjava. This should be enough for other Java modules to be able to reference this. I have verified that this is the case by installing it to a local repository and referencing it from my own projects.Please note that doing this has no impact on non modular applications, which will simply ignore the attribute, both on older and newer JDKs. This change is an easy first step towards module support.