Skip to content

fix: return error on non-200 config push#3710

Open
dilshad-aee wants to merge 2 commits intokeploy:mainfrom
dilshad-aee:fix/push-config-change-non-200
Open

fix: return error on non-200 config push#3710
dilshad-aee wants to merge 2 commits intokeploy:mainfrom
dilshad-aee:fix/push-config-change-non-200

Conversation

@dilshad-aee
Copy link

@dilshad-aee dilshad-aee commented Feb 3, 2026

Describe the changes that are made

  • Return a real error when /mock/pr responds with non-200
  • Include status code + response body in the error
  • Add tests covering non-200 responses and invalid JSON

Links & References

Closes: #3708

🔗 Related PRs

  • NA

🐞 Related Issues

📄 Related Documents

  • NA

What type of PR is this? (check all applicable)

  • 📦 Chore
  • 🍕 Feature
  • 🐞 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🔁 CI
  • ⏩ Revert

Added e2e test pipeline?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added comments for hard-to-understand areas?

  • 👍 yes
  • 🙅 no, because the code is self-explanatory

Added to documentation?

  • 📜 README.md
  • 📓 Wiki
  • 🙅 no documentation needed

Are there any sample code or steps to test the changes?

  • 👍 yes, mentioned below
  • 🙅 no, because it is not needed

Steps to test

  • go test ./pkg/service/replay

Self Review done?

  • ✅ yes
  • ❌ no, because I need help

Any relevant screenshots, recordings or logs?

  • NA

Signed-off-by: dilshad <dilshadariyil343@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

The CLA check failed. Please ensure you have:

  • Signed the CLA by commenting 'I have read the CLA Document and I hereby sign the CLA.'
  • Used the correct email address in your commits (matches the one you used to sign the CLA).

After fixing these issues, comment 'recheck' to trigger the workflow again.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@dilshad-aee
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@dilshad-aee
Copy link
Author

Hey @gouravkrosx @Sarthak160 👋
The PR is ready and all updates are pushed.
Requesting a review whenever you’re free. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant