Merged
Conversation
tarasyyyk
requested changes
Feb 26, 2020
Collaborator
tarasyyyk
left a comment
There was a problem hiding this comment.
Very good translation!
Please, made small corrections and I'll merge this PR.
| # Стандарт оформлення коду | ||
|
|
||
| Our code must be as clean and easy to read as possible. | ||
| Наш код повинен бути настільки чистим та зрозумілим наскільки це можливо. |
Collaborator
There was a problem hiding this comment.
«настільки зрозумілим та читабельним, наскільки це можливо»
| --> | ||
|
|
||
| Now let's discuss the rules and reasons for them in detail. | ||
| Давайте розберемо ці правила і причини їх з'явлення більш детально. |
Collaborator
There was a problem hiding this comment.
«Давайте детальніше розглянемо ці правила і причини їх появи»
Contributor
|
Please make the requested changes. After it, add a comment "/done". |
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Contributor
Author
|
/done |
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
tarasyyyk
requested changes
Feb 27, 2020
Collaborator
tarasyyyk
left a comment
There was a problem hiding this comment.
The last small correction need to be fixed before merge.
Contributor
|
Please make the requested changes. After it, add a comment "/done". |
tarasyyyk
approved these changes
Feb 27, 2020
Collaborator
tarasyyyk
left a comment
There was a problem hiding this comment.
Great job! Thank you for contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt to prepare PR for translation (as mentioned previously SVG will be changed using YAML file later). Please review and comment.