Address some possible issues in translation of 1.2.11#119
Merged
tarasyyyk merged 2 commits intojavascript-tutorial:masterfrom Oct 4, 2020
vsemozhetbyt:1.2.11
Merged
Address some possible issues in translation of 1.2.11#119tarasyyyk merged 2 commits intojavascript-tutorial:masterfrom vsemozhetbyt:1.2.11
tarasyyyk merged 2 commits intojavascript-tutorial:masterfrom
vsemozhetbyt:1.2.11
Conversation
tarasyyyk
approved these changes
Oct 3, 2020
| @@ -1 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="599" height="493" viewBox="0 0 599 493"><defs><style>@import url(https://fonts.googleapis.com/css?family=Open+Sans:bold,italic,bolditalic%7CPT+Mono);@font-face{font-family:'PT Mono';font-weight:700;font-style:normal;src:local('PT MonoBold'),url(/font/PTMonoBold.woff2) format('woff2'),url(/font/PTMonoBold.woff) format('woff'),url(/font/PTMonoBold.ttf) format('truetype')}</style></defs><g id="combined" fill="none" fill-rule="evenodd" stroke="none" stroke-width="1"><g id="ifelse_task.svg"><path id="Path-1218-Copy" fill="#EE6B47" fill-rule="nonzero" d="M529.5 326.5v93h8l-9.5 19-9.5-19h8v-90h-82v-3h85zM372.5 131.5v126h8l-9.5 19-9.5-19h8v-123h-82v-3h85z"/><g id="Rectangle-1-+-Корень" transform="translate(180 4)"><rect id="Rectangle-1" width="78" height="28" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="14"/><text id="Begin" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="21" y="20">Begin</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-2" transform="translate(0 243)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Canceled" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="36.647" y="29">Canceled</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-5" transform="translate(150 438)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Canceled" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="36.647" y="29">Canceled</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-6" transform="translate(458 438)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Welcome!" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="35.093" y="29">Welcome!</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-4" transform="translate(154 243)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="I-don't-know-you" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="12.773" y="28">I don't know you</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-7" transform="translate(296 438)"><rect id="Rectangle-1" width="147" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Wrong-password" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="18.152" y="29">Wrong password</tspan></text></g><path id="Line" fill="#EE6B47" fill-rule="nonzero" d="M222 35v23.049l8 .001-9.5 19-9.5-19 8-.001V35h3z"/><path id="Path-1218" fill="#EE6B47" fill-rule="nonzero" d="M131.691 131.367v3l-59.302-.001v85.181h8l-9.5 19-9.5-19h8v-88.18h62.302z"/><path id="Path-1218-Copy-2" fill="#EE6B47" fill-rule="nonzero" d="M281.691 326.367v3l-59.307-.001-.319 90.139 8 .029-9.567 18.966-9.433-19.033 8 .027.324-91.633.005-1.494h62.297z"/><g id="Rectangle-354-+-Каково-“официальное”" transform="translate(127 81)"><path id="Rectangle-354" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" d="M2.06 52l91.55 50.856L185.161 52 93.611 1.144 2.058 52z"/><text id="Who's-there?" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="51.722" y="55">Who's there?</tspan></text></g><g id="Rectangle-354-+-Каково-“официальное”-Copy" transform="translate(277 276)"><path id="Rectangle-354" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" d="M2.06 52l91.55 50.856L185.161 52 93.611 1.144 2.058 52z"/><text id="Password?" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="59.03" y="55">Password?</tspan></text></g><g id="Rectangle-356-+-Отмена" transform="translate(39 191)"><path id="Rectangle-356" fill="#FFF" d="M0 2h60v20H0z"/><text id="Cancel" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="7.5" y="15">Cancel</tspan></text></g><g id="Rectangle-356-+-Отмена-Copy" transform="translate(189 384)"><path id="Rectangle-356" fill="#FFF" d="M0 2h60v20H0z"/><text id="Cancel" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="7.5" y="15">Cancel</tspan></text></g><g id="Rectangle-356-Copy-+-“Админ”" transform="translate(341 191)"><path id="Rectangle-356-Copy" fill="#FFF" d="M0 2h60v20H0z"/><text id="Admin" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="7.703" y="15">Admin</tspan></text></g><g id="Rectangle-356-Copy-+-“Админ”-Copy" transform="translate(493 384)"><path id="Rectangle-356-Copy" fill="#FFF" d="M7 2h60v20H7z"/><text id="TheMaster" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x=".096" y="15">TheMaster</tspan></text></g><path id="Line" fill="#EE6B47" fill-rule="nonzero" d="M223 182v42.56h8l-9.5 19-9.5-19h8V182h3z"/><path id="Line-Copy-2" fill="#EE6B47" fill-rule="nonzero" d="M373 377v42.56h8l-9.5 19-9.5-19h8V377h3z"/><g id="Rectangle-356-Copy-2-+-“Админ”-Copy" transform="translate(191 191)"><path id="Rectangle-356-Copy-2" fill="#FFF" d="M0 2h60v20H0z"/><text id="Other" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="9.996" y="15">Other</tspan></text></g><g id="Rectangle-356-Copy-2-+-“Админ”-Copy-Copy" transform="translate(341 384)"><path id="Rectangle-356-Copy-2" fill="#FFF" d="M0 2h60v20H0z"/><text id="Other" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="9.996" y="15">Other</tspan></text></g></g></g></svg> No newline at end of file | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="599" height="493" viewBox="0 0 599 493"><defs><style>@import url(https://fonts.googleapis.com/css?family=Open+Sans:bold,italic,bolditalic%7CPT+Mono);@font-face{font-family:'PT Mono';font-weight:700;font-style:normal;src:local('PT MonoBold'),url(/font/PTMonoBold.woff2) format('woff2'),url(/font/PTMonoBold.woff) format('woff'),url(/font/PTMonoBold.ttf) format('truetype')}</style></defs><g id="combined" fill="none" fill-rule="evenodd" stroke="none" stroke-width="1"><g id="ifelse_task.svg"><path id="Path-1218-Copy" fill="#EE6B47" fill-rule="nonzero" d="M529.5 326.5v93h8l-9.5 19-9.5-19h8v-90h-82v-3h85zM372.5 131.5v126h8l-9.5 19-9.5-19h8v-123h-82v-3h85z"/><g id="Rectangle-1-+-Корень" transform="translate(180 4)"><rect id="Rectangle-1" width="78" height="28" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="14"/><text id="Begin" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="10" y="20">Початок</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-2" transform="translate(0 243)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Canceled" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="30" y="29">Скасовано</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-5" transform="translate(150 438)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Canceled" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="30" y="29">Скасовано</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-6" transform="translate(458 438)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Welcome!" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="13" font-weight="normal"><tspan x="5" y="29">Ласкаво просимо!</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-4" transform="translate(154 243)"><rect id="Rectangle-1" width="131" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="I-don't-know-you" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="15" y="28">Я вас не знаю</tspan></text></g><g id="Rectangle-1-+-Корень-Copy-7" transform="translate(296 438)"><rect id="Rectangle-1" width="147" height="49" x="1" y="1" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" rx="24.5"/><text id="Wrong-password" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="12" font-weight="normal"><tspan x="2" y="29">Неправильний пароль</tspan></text></g><path id="Line" fill="#EE6B47" fill-rule="nonzero" d="M222 35v23.049l8 .001-9.5 19-9.5-19 8-.001V35h3z"/><path id="Path-1218" fill="#EE6B47" fill-rule="nonzero" d="M131.691 131.367v3l-59.302-.001v85.181h8l-9.5 19-9.5-19h8v-88.18h62.302z"/><path id="Path-1218-Copy-2" fill="#EE6B47" fill-rule="nonzero" d="M281.691 326.367v3l-59.307-.001-.319 90.139 8 .029-9.567 18.966-9.433-19.033 8 .027.324-91.633.005-1.494h62.297z"/><g id="Rectangle-354-+-Каково-“официальное”" transform="translate(127 81)"><path id="Rectangle-354" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" d="M2.06 52l91.55 50.856L185.161 52 93.611 1.144 2.058 52z"/><text id="Who's-there?" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="60" y="55">Хто там?</tspan></text></g><g id="Rectangle-354-+-Каково-“официальное”-Copy" transform="translate(277 276)"><path id="Rectangle-354" fill="#FFF9EB" stroke="#E8C48E" stroke-width="2" d="M2.06 52l91.55 50.856L185.161 52 93.611 1.144 2.058 52z"/><text id="Password?" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="65" y="55">Пароль?</tspan></text></g><g id="Rectangle-356-+-Отмена" transform="translate(39 191)"><path id="Rectangle-356" fill="#FFF" d="M0 2h60v20H0z"/><text id="Cancel" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="11" font-weight="normal"><tspan x="0" y="15">Скасовано</tspan></text></g><g id="Rectangle-356-+-Отмена-Copy" transform="translate(189 384)"><path id="Rectangle-356" fill="#FFF" d="M0 2h60v20H0z"/><text id="Cancel" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="11" font-weight="normal"><tspan x="0" y="15">Скасовано</tspan></text></g><g id="Rectangle-356-Copy-+-“Админ”" transform="translate(341 191)"><path id="Rectangle-356-Copy" fill="#FFF" d="M0 2h60v20H0z"/><text id="Admin" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="7.703" y="15">Admin</tspan></text></g><g id="Rectangle-356-Copy-+-“Админ”-Copy" transform="translate(493 384)"><path id="Rectangle-356-Copy" fill="#FFF" d="M7 2h60v20H7z"/><text id="TheMaster" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="12" font-weight="normal"><tspan x="8" y="15">Господар</tspan></text></g><path id="Line" fill="#EE6B47" fill-rule="nonzero" d="M223 182v42.56h8l-9.5 19-9.5-19h8V182h3z"/><path id="Line-Copy-2" fill="#EE6B47" fill-rule="nonzero" d="M373 377v42.56h8l-9.5 19-9.5-19h8V377h3z"/><g id="Rectangle-356-Copy-2-+-“Админ”-Copy" transform="translate(191 191)"><path id="Rectangle-356-Copy-2" fill="#FFF" d="M0 2h60v20H0z"/><text id="Other" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="12" y="15">Інше</tspan></text></g><g id="Rectangle-356-Copy-2-+-“Админ”-Copy-Copy" transform="translate(341 384)"><path id="Rectangle-356-Copy-2" fill="#FFF" d="M0 2h60v20H0z"/><text id="Other" fill="#8A704D" font-family="OpenSans-Regular, Open Sans" font-size="14" font-weight="normal"><tspan x="12" y="15">Інше</tspan></text></g></g></g></svg> No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Чи можна словосполучення «Неправильний пароль» відцентрувати?
Contributor
Author
There was a problem hiding this comment.
Я спробую. Як щодо "Скасовано" та "Ласкаво просимо"? Вони теж, здається, відчутно зсунуті ліворуч.
Collaborator
There was a problem hiding this comment.
Було б добре і їх відцентрувати.
Contributor
Author
There was a problem hiding this comment.
Тут виявляється така дивна річ. Я пригадую, що наче центрував усі блоки, тому здивувався, чому вони тепер невідцентровані. І от, коли я відкриваю файл локально, там усе гаразд, тому що написи відображаються шрифтом, заданим у файлі. Але коли я відкриваю файл з коміту через сайт GitHub-у, написи зсунуті і відображені іншим шрифтом. Тому, по-перше, я не маю змоги відцентрувати їх, тому що в локальному файлі в мене і так все гаразд. По-друге, думаю, в остаточному варіанті вони будуть відцентровані, оскільки на сайті javascript.info все відображається правильним шрифтом.
Порівняйте, що я бачу в локальному файлі і файлі с GitHub-у (ви, мабуть, бачите останнє — спробуйте зберегти файл локально і відркити у Хромі, цікаво, як у вас будет в цьому випадку):
Скріншоти:
Collaborator
There was a problem hiding this comment.
Згадав, що в мене теж таке було. Все добре, остаточний варіант (на сайті) буде ок.
Можете запустити локальний сервер, щоб точно бачити, як буде виглядати переклад.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Попередній PR з обговоренням: #112
Я постарався застосувати усі певні виправлення у другому коміті, перший коміт ідентичний.