Interaction: alert, prompt, confirm#170
Closed
andreimuntean1 wants to merge 5 commits intojavascript-tutorial:masterfrom
Closed
Interaction: alert, prompt, confirm#170andreimuntean1 wants to merge 5 commits intojavascript-tutorial:masterfrom
andreimuntean1 wants to merge 5 commits intojavascript-tutorial:masterfrom
Conversation
|
|
bogdanbacosca
requested changes
Jan 23, 2023
Contributor
There was a problem hiding this comment.
Te rog să dai revert la 13-while-for, cum ai făcut la celălalt PR.
Trebuie să avem doar 1 PR pentru fiecare articol.
Am lăsat 2 comentarii în cod.
Pe scurt: trebuie ca formatul markdown să fie identic cu cel original, iar numele variabilelor să rămână netraduse.
Te rog să faci schimbările astea mai intâi prin tot codul.
Dacă ai mai multe nelămuriri, citește fișierul README.md din repo sau trimite-mi un mail.
| let name = prompt("What is your name?", ""); | ||
| alert(name); | ||
| ```js | ||
| let nume = prompt("Cum te numești?", ""); |
Contributor
There was a problem hiding this comment.
Suggested change
| let nume = prompt("Cum te numești?", ""); | |
| let name = prompt("Cum te numești?", ""); |
numele variabilelor nu se traduc.
|
Please make the requested changes. After it, add a comment "/done". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.