Skip to content

Character classes#143

Closed
fsdude wants to merge 23 commits intojavascript-tutorial:masterfrom
fsdude:02-regexp-character-classes
Closed

Character classes#143
fsdude wants to merge 23 commits intojavascript-tutorial:masterfrom
fsdude:02-regexp-character-classes

Conversation

@fsdude
Copy link
Contributor

@fsdude fsdude commented May 25, 2020

@javascript-translate-bot javascript-translate-bot requested a review from a team May 25, 2020 22:27
@iliakan iliakan mentioned this pull request May 25, 2020
Open
odsantos added a commit that referenced this pull request May 26, 2020
@odsantos
Transfer translation contents #143
eaba2dc
@odsantos
Copy link
Contributor

odsantos commented Dec 8, 2020

Hi @fsdude would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you.

@fsdude
Copy link
Contributor Author

fsdude commented Dec 9, 2020

Hi @fsdude would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you.

Hello! Yeah.. lately I've been busy with some work. I don't know if I'll be able to fix this soon, sorry for that
Thanks by the way =)

@odsantos
Copy link
Contributor

odsantos commented Dec 9, 2020

@fsdude Thank you.

@CLAassistant
Copy link

CLAassistant commented Dec 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

odsantos
odsantos requested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kiniggit, @luizclr, @adriavieira314, @Mr-Saxobeat, please since @fsdude might be unavailable I would appreciate if any of you could review this PR #143 , including my revision.
Thank you.

@javascript-translate-bot
Copy link

javascript-translate-bot commented May 17, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

odsantos
odsantos reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @fsdude is not available, I applied the changes and will wait for another reviewer.

odsantos added a commit that referenced this pull request Dec 14, 2022
@odsantos
Delete solution.md
b8a8832 
Update #143
@odsantos
Copy link
Contributor

odsantos commented Jan 23, 2023

Closing and re-opening a new one for resolving conflict.

@odsantos odsantos closed this Jan 23, 2023
@odsantos odsantos mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantos odsantos odsantos requested changes

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fsdude @odsantos @CLAassistant @javascript-translate-bot