german translation of code editors by higoka · Pull Request #5 · javascript-tutorial/de.javascript.info

higoka · 2020-01-14T10:00:57Z

No description provided.

claassistantio · 2020-01-14T10:02:25Z

All committers have signed the CLA.

1-js/01-getting-started/3-code-editors/article.md

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

1H0

I think we should agree that we all translate the article in the du-form. So that we are consistent through the articles.

1-js/01-getting-started/3-code-editors/article.md

javascript-translate-bot · 2020-01-20T11:26:31Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

1H0 · 2020-01-20T11:36:05Z

Just saw that the topic was not reserved by you and that @MichFriee reserved and translated the page in another PR. Please make sure to always check first, if the article isn't already taken and to reserve it first...

Ok when I close this PR and you take another article?

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>

higoka · 2020-01-20T14:13:12Z

/done

1-js/01-getting-started/3-code-editors/article.md

javascript-translate-bot · 2020-01-21T13:15:36Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>

higoka · 2020-01-21T14:06:32Z

/done

MichFrie · 2020-01-21T19:07:20Z

Hi 1HO, sorry for the confusion, please feel free to close my commit and use the other translation if that's helpful

1H0 · 2020-01-24T13:13:04Z

Hi @MichFrie!

You did everything right! You reserved the topic first, so it's fine! Just make sure to implement the changes requesten on your PR. Then we can merge your one!

I think i have to close this one now... Since it was translated twice...

1H0 · 2020-01-24T13:15:48Z

Duplicated translation... @MichFrie reserved the Topic properly, because of that we'll merge his one when the requested changes are implemented.

Sorry @higoka ... 😞 Make sure to properly claim the topics in the future!

Updated Repo

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

german translation

7214c0b

javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 14, 2020

javascript-translate-bot requested a review from a team January 14, 2020 10:01

christianhegedues reviewed Jan 14, 2020

View reviewed changes

higoka and others added 7 commits January 15, 2020 07:19

Update 1-js/01-getting-started/3-code-editors/article.md

6d536e7

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

3fd85e7

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

3c3a021

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

03f41a7

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

92f6ee4

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

45f6f13

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

17665a0

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

1H0 suggested changes Jan 20, 2020

View reviewed changes

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 20, 2020

higoka and others added 5 commits January 20, 2020 15:11

Update 1-js/01-getting-started/3-code-editors/article.md

69b9025

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

a53f3a1

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

7857da3

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

5422b7c

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>

Update 1-js/01-getting-started/3-code-editors/article.md

9ad87eb

Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 20, 2020

javascript-translate-bot requested a review from a team January 20, 2020 14:13

1H0 added the partially reviewed Last review only took a part of the article. Full re-review (not just changes since last) required label Jan 21, 2020

JoeGab suggested changes Jan 21, 2020

View reviewed changes

1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved

1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved

1-js/01-getting-started/3-code-editors/article.md Outdated Show resolved Hide resolved

javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 21, 2020

higoka and others added 3 commits January 21, 2020 15:05

Update 1-js/01-getting-started/3-code-editors/article.md

a9f0e7b

Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>

Update 1-js/01-getting-started/3-code-editors/article.md

5e49306

Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>

Update 1-js/01-getting-started/3-code-editors/article.md

389855d

Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>

javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 21, 2020

1H0 closed this Jan 24, 2020

javascript-translate-bot pushed a commit that referenced this pull request Mar 24, 2020

Merge pull request #5 from javascript-tutorial/master

4f6356b

Updated Repo

SirCodewright added a commit to SirCodewright/de.javascript.info that referenced this pull request Apr 5, 2020

Review issues / update javascript-tutorial#5

d2a7712

Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>

Uh oh!

Conversation

higoka commented Jan 14, 2020

Uh oh!

claassistantio commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

1H0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jan 20, 2020

Uh oh!

1H0 commented Jan 20, 2020

Uh oh!

higoka commented Jan 20, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jan 21, 2020

Uh oh!

higoka commented Jan 21, 2020

Uh oh!

MichFrie commented Jan 21, 2020

Uh oh!

1H0 commented Jan 24, 2020

Uh oh!

1H0 commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

claassistantio commented Jan 14, 2020 •

edited

Loading