Merged
Conversation
|
|
ahamed
reviewed
May 10, 2020
Contributor
ahamed
left a comment
There was a problem hiding this comment.
Here, with some typoes, I've given some suggestions. You can approve of them.
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/solution.md
Outdated
Show resolved
Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md
Outdated
Show resolved
Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md
Outdated
Show resolved
Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md
Outdated
Show resolved
Hide resolved
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md
Show resolved
Hide resolved
| @@ -281,7 +284,7 @@ alert(str); // 0..9A..Za..z | |||
|
|
|||
| The `yield*` directive *delegates* the execution to another generator. This term means that `yield* gen` iterates over the generator `gen` and transparently forwards its yields outside. As if the values were yielded by the outer generator. | |||
Contributor
There was a problem hiding this comment.
You should translate this too.
…erator/solution.md Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
…erator/task.md Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
…erator/task.md Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
…erator/task.md Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
…erator/task.md Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Co-authored-by: Sajeeb Ahamed <sajeeb07ahamed@gmail.com>
Contributor
Author
thanks, approved :) |
jaamaalxyz
reviewed
Jun 6, 2020
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/solution.md
Outdated
Show resolved
Hide resolved
jaamaalxyz
reviewed
Jun 6, 2020
1-js/12-generators-iterators/1-generators/01-pseudo-random-generator/task.md
Outdated
Show resolved
Hide resolved
jaamaalxyz
reviewed
Jun 6, 2020
jaamaalxyz
reviewed
Jun 6, 2020
jaamaalxyz
reviewed
Jun 6, 2020
jaamaalxyz
reviewed
Jun 6, 2020
jaamaalxyz
reviewed
Jun 6, 2020
jaamaalxyz
requested changes
Jun 6, 2020
Member
jaamaalxyz
left a comment
There was a problem hiding this comment.
সামান্য কিছু চেঞ্জ আছে। খুব ভালো হয়েছে। চেঞ্জ গুলো কমপ্লিট করে ./done লিখে কমেন্ট করুন।
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
…erator/task.md Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
…erator/solution.md Co-authored-by: Md. Jamal Uddin <jamal-pb95@users.noreply.github.com>
Contributor
Author
|
done |
jaamaalxyz
approved these changes
Jun 6, 2020
Member
jaamaalxyz
left a comment
There was a problem hiding this comment.
thanks for nice contribution. I hope we will get more contributions from you soon.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I try to translate the Generators chapter. It's my first translation. Let me know if anything wrong.
Thanks :)