Update Prometheus client version to ~2.14#7496
Open
PandaLIU-1111 wants to merge 3 commits intohyperf:masterfrom
Hidden character warning
The head ref may contain hidden characters: "\u9002\u914d\u65b0\u7248\u672c\u666e\u7f57\u7c73\u4fee\u65af"
Open
Update Prometheus client version to ~2.14#7496PandaLIU-1111 wants to merge 3 commits intohyperf:masterfrom
PandaLIU-1111 wants to merge 3 commits intohyperf:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Prometheus client library from version ~2.2 to ~2.14 and adds a new updateSummary method to the Redis adapter for Prometheus metrics. The update enables support for newer Prometheus client features and implements summary metric tracking functionality.
- Updates Prometheus client dependency from version ~2.2.0 to ~2.14
- Adds
updateSummarymethod to handle summary metric operations in Redis - Updates composer dependency requirements in both main and metric package configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/metric/src/Adapter/Prometheus/Redis.php | Adds new updateSummary method to handle summary metrics with sum, count, and value tracking |
| src/metric/composer.json | Updates Prometheus client version requirement in suggest section |
| composer.json | Updates Prometheus client version constraint in dev dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Prometheus client version to ~2.14