fix: fix a boolean instead of file name & prevent from closing BytesIO object#4
Merged
alissonlauffer merged 2 commits intomainfrom Dec 4, 2023
Merged
Conversation
HitaloM
approved these changes
Dec 4, 2023
Member
HitaloM
left a comment
There was a problem hiding this comment.
It looks good to me and fixes the issue. You can merge the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues, one caused by a typo where a
Path(audio).is_file()(bool) was passed tofile_namein send_audio.py. The other was caused by closing the BytesIO object prematurely, making the returned BytesIO object unreadable.Type of change
Checklist