fix(handle-download): create temp filename from filename#3
Merged
alissonlauffer merged 1 commit intomainfrom Dec 3, 2023
Merged
fix(handle-download): create temp filename from filename#3alissonlauffer merged 1 commit intomainfrom
alissonlauffer merged 1 commit intomainfrom
Conversation
currently, the filename was being created from the temp filename
HitaloM
approved these changes
Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the filename was being created from the suffix of the temp filename, thus leading to the file always be called
.temp. This fixes it and also does the reverse: It now creates the temp filename from the actual filename, which feels better to me.Type of change
Checklist