fix: make quiz explanation optional#21
Merged
HitaloM merged 3 commits intohydrogram:devfrom Mar 23, 2024
Midblyte:explanation-patch
Merged
fix: make quiz explanation optional#21HitaloM merged 3 commits intohydrogram:devfrom Midblyte:explanation-patch
HitaloM merged 3 commits intohydrogram:devfrom
Midblyte:explanation-patch
Conversation
HitaloM
approved these changes
Mar 18, 2024
Member
HitaloM
left a comment
There was a problem hiding this comment.
I've reviewed the changes and everything looks good to me. Great work on this pull request!
tangyoha
pushed a commit
to tangyoha/hydrogram
that referenced
this pull request
Jul 14, 2024
Co-authored-by: Colin <colin@colinshark.de> Co-authored-by: Dan <14043624+delivrance@users.noreply.github.com> Co-authored-by: Akkia <AkkiaS7@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, there's no way to create a poll ("quiz" type) without any explanation using Client.send_poll.
When explanation parameter is not passed (explanation=None), current code stringifies None to "None".
But, when explanation=None, explanation_entities is required to be None too (explanation_entities=None), while current solution forces explanation_entities to always be a list.
This patch ensures that the required cases get handled properly, fixing the current bugs.
Type of change
How Has This Been Tested?
I manually tested various combinations of parameters (explanation and explanation_entities) of Client.send_poll.
Checklist