Add HTTP body compression between pipeline-manager and pipelines, raise the limit#5626
Open
Karakatiza666 wants to merge 2 commits intomainfrom
Open
Add HTTP body compression between pipeline-manager and pipelines, raise the limit#5626Karakatiza666 wants to merge 2 commits intomainfrom
Karakatiza666 wants to merge 2 commits intomainfrom
Conversation
…r and pipelines, raise the limit Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Signed-off-by: feldera-bot <feldera-bot@feldera.com>
0356b4e to
77ce2ee
Compare
Contributor
|
This needs unit and integration tests. I'm also nervous about disabling compression on proxied streaming requests. |
Contributor
Author
|
The compression was already disabled for streaming requests because it breaks the on-demand data streaming - the stream does not send the data as soon as it's available and instead buffers to collect a complete encoding chunk |
ryzhyk
reviewed
Feb 13, 2026
| .headers() | ||
| .into_iter() | ||
| .filter(|(h, _)| *h != "connection") | ||
| .filter(|(h, _)| *h != "connection" && *h != "accept-encoding") |
Contributor
There was a problem hiding this comment.
This looks too subtle. I hope we find a more bullet-proof way not to compress stuff that shouldn't be compressed.
Contributor
Author
There was a problem hiding this comment.
Well, for now we have abstracted the proxying to the pipeline process behind two functions - streaming and non-streaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was caused by the artifical RESPONSE_SIZE_LIMIT for the uncompressed response body size for requests from pipeline-manager to the pipeline server.
Fix #5624: [PROFILE] The circuit profile should be compressed
Testing:
With an artificially lowered RESPONSE_SIZE_LIMIT I saw the same error when downloading the support bundle for a small pipeline.
With these changes, after recompiling the pipeline-manager and the pipeline Performance, Logs and Changes Stream tabs that use proxied streaming requests worked as expected, and I was able to download the support bundle with valid contents.