Conversation
gz
left a comment
There was a problem hiding this comment.
lgtm but probably better if @abhizer reviews this so we'll defer to him
make sure to add a test to the python sdk itself to test this method @abhizer can you walk @jyotshnayaparla-00 through the steps to do that?
for ow you can run the Merge Queue Job on this branch manually to see if it would pass
|
also can you squash the commits into a single one on that branch? |
| working-directory: python | ||
| env: | ||
| FELDERA_HOST: http://localhost:8080 | ||
| PYTHONPATH: ${{ github.workspace }}/python |
There was a problem hiding this comment.
OIDC_TEST_CLIENT_SECRET: ${{ secrets.OIDC_TEST_CLIENT_SECRET }}
OIDC_TEST_USERNAME: ${{ secrets.OIDC_TEST_USERNAME }}
OIDC_TEST_PASSWORD: ${{ secrets.OIDC_TEST_PASSWORD }}
you might have to set those here too (from above) @abhizer can say this for sure
There was a problem hiding this comment.
Update done: added SDK test, squashed into one commit, and added OIDC env vars. Ready for @abhizer review.
There was a problem hiding this comment.
great note that you won't be able to push merge commits into main (the CI won't allow you to merge).. instead of merging main into my branch i just set up an alias git purr in my gitconfig that I use to rebase my branches onlatest main
here is my alias list for ~/.gitconfig maybe you find some of them useful
[alias]
br = branch --sort=-committerdate
cm = commit -s -S
lg = log --color --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit
purr = pull --rebase
st = status -sb
co = checkout
so = commit --amend -s -c
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
a40c4f0 to
9223811
Compare
|
Fixed the CI failure by forcing |
f810d90 to
f03b628
Compare
|
The CI API key creation now uses OIDC token when configured (avoids 401 “API key not set”). |
|
@jyotshnayaparla-00 can you squash all commits into just 2
(git rebase -i should work) |
3ba1689 to
e21c9ee
Compare
|
Updated the Create API key step to use an OIDC token when configured and pushed to add-api-key-ci. |
152587a to
5a34690
Compare
Adds SDK method to create API keys and wires CI workflow to generate and export FELDERA_API_KEY before test.bash.