[feldera-types] Implement some traits for multihost samply profiles.#5553
Merged
[feldera-types] Implement some traits for multihost samply profiles.#5553
Conversation
Signed-off-by: Ben Pfaff <blp@feldera.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements additional traits (Serialize and Default) for structs related to samply profile query parameters in the feldera-types crate. The changes standardize the implementation pattern by using Default trait instead of standalone default functions and adding serialization support.
Changes:
- Added
Serializetrait toSamplyProfileParamsandSamplyProfileGetParams - Replaced standalone
default_samply_profile_duration()function withDefaulttrait implementation forSamplyProfileParams - Added
Defaulttrait toSamplyProfileGetParamsand applied#[serde(default)]at the struct level
mihaibudiu
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.