[adapters] Log detailed checkpoint info on startup.#5546
Merged
Conversation
Log metadata about the checkpoint that the pipeline is starting from. We may want to make it less detailed or decrease log level to debug in the future if this info becomes available from the manager via the list checkpoint API prior to starting the pipeline. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
Contributor
Author
|
Example: |
mihaibudiu
approved these changes
Feb 1, 2026
| } | ||
|
|
||
| impl Checkpoint { | ||
| pub fn display_summary(&self) -> String { |
Contributor
There was a problem hiding this comment.
why "display" and not just "summary"?
Contributor
Author
There was a problem hiding this comment.
The name emphasizes that the summary is formatted for display purposes. I think this is somewhat common in Rust.
Contributor
|
Is it difficult to format |
Contributor
Author
I already did this. The example doesn't reflect the latest version, sorry |
Member
|
The build failure above, at https://github.com/feldera/feldera/actions/runs/21582267321/job/62181961460, is a new one for me. I had to download the log archive to get it, and the failure looks like: Beats me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log metadata about the checkpoint that the pipeline is starting from. We may want to make it less detailed or decrease log level to debug in the future if this info becomes available from the manager via the list checkpoint API prior to starting the pipeline.