Conversation
Co-authored-by: gz <127654+gz@users.noreply.github.com>
…b-token Co-authored-by: gz <127654+gz@users.noreply.github.com> Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
85454d1 to
80a3151
Compare
jyotshnayaparla-00
left a comment
There was a problem hiding this comment.
This integrates crates/fda/test.bash into the platform integration CI workflow. Verified the artifact download, executable permissions, and test execution logic.
There was a problem hiding this comment.
looks good, note that we do not allow merge commits on main in our settings, the history has to be linear. instead of doing a merge commit to update to latest main you can run:
git pull --rebase
also I'm not quite sure that it will pass CI because it is using auth and a TLS cert in the test above on line 220 but but we don't set it here, but you can run it and see what happens, alternatively you can launch the pipeline manager locally (with https+auth) like we do it in this CI job and see you can execute the test.bash script against it
|
it also looks like I'm not allowed to approve this
so you have to get permission from someone else :) |
|
Okay sure Gerd!
… On Feb 3, 2026, at 3:35 PM, Gerd Zellweger ***@***.***> wrote:
gz
left a comment
(feldera/feldera#5172)
<#5172 (comment)>
it also looks like I'm not allowed to approve this
At least 1 approving review is required by reviewers with write access. Approvals from users that collaborated with the coding agent on changes will not satisfy review requirements.
so you have to get permission from someone else :)
—
Reply to this email directly, view it on GitHub <#5172 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/B426GUKT5QV2XTFSYQ3BNEL4KEA7JAVCNFSM6AAAAACNC5GMOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNBTGUYTMMBUGE>.
You are receiving this because you commented.
|
Integrates
crates/fda/test.bashinto the CI pipeline as part of platform integration tests.Changes
Added three steps to the
oss-platform-testsjob in.github/workflows/test-integration-platform.yml:fdabinary artifact using${{ matrix.target }}for architecture compatibilitytest.bashagainst the existing pipeline-manager serviceEnvironment:
FELDERA_HOST=http://localhost:8080,FELDERA_API_KEY=""(no-auth mode)Validates CLI functionality: pipeline CRUD, UDF handling, connectors, transactions, support bundles.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes
None.
Original prompt
felderarepo CI #5152💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.