fix: Correct typo 'occured' to 'occurred'#5950
fix: Correct typo 'occured' to 'occurred'#5950thecaptain789 wants to merge 2 commits intofeast-dev:masterfrom
Conversation
| conflict_occurred = "dependency conflicts" in err and "ERROR" not in err | ||
| assert not conflict_occurred, "Dependency conflict detected during installation" |
There was a problem hiding this comment.
🟡 Dependency conflict check condition is logically inverted, making the test ineffective
The condition on line 31 uses and to combine two checks, but this means actual pip dependency conflicts are never caught.
Root Cause
When pip detects dependency conflicts but still succeeds (exit code 0), it outputs to stderr a message like:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. Running pip check may reveal dependency conflicts.
The current condition is:
conflict_occurred = "dependency conflicts" in err and "ERROR" not in errSince pip's conflict message contains BOTH "dependency conflicts" AND "ERROR", the evaluation is:
"dependency conflicts" in err→True"ERROR" not in err→FalseTrue and False→False
So conflict_occurred is False, and assert not False passes. The test will never detect actual dependency conflicts from pip.
The condition should likely be:
conflict_occurred = "dependency conflicts" in err or "ERROR" in error simply:
conflict_occurred = "dependency conflicts" in errImpact: The test is meant to catch dependency conflicts between Feast and KServe, but it will always pass regardless of whether conflicts exist, defeating its purpose.
| conflict_occurred = "dependency conflicts" in err and "ERROR" not in err | |
| assert not conflict_occurred, "Dependency conflict detected during installation" | |
| conflict_occurred = "dependency conflicts" in err | |
| assert not conflict_occurred, "Dependency conflict detected during installation" | |
Was this helpful? React with 👍 or 👎 to provide feedback.
143d798 to
b1980d1
Compare
|
@thecaptain789 Please sign the commit, you can hit UI button to pass DCO |
shuchu
left a comment
There was a problem hiding this comment.
please sign off your commit.
Fixed typo in variable name in dependency conflict test.