feat(cli): Updated feast init demo by adding rag template#5946
feat(cli): Updated feast init demo by adding rag template#5946Vperiodt wants to merge 14 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
sdk/python/feast/cli/cli.py
Outdated
| help="Directory path where the repository will be created (default: create subdirectory with project name)", | ||
| ) | ||
| def init_command(project_directory, minimal: bool, template: str, repo_path: str): | ||
| @click.option( |
There was a problem hiding this comment.
IMO, we should just add rag to the default template and not do scenarios.
There was a problem hiding this comment.
suggestion are addressed, may be I can make one more PR for recommendation engine one, will keep this PR scope small as of now, thanks !
There was a problem hiding this comment.
@franciscojavierarceo The ideology of scenario is coming from #5264. The template are backend-based and without much of user context to it WHEREAS scenarios are real production-like deployments that customers can directly try and gain experience of feast usage with given Notebooks/Readme in deployment scenarios. So I would prefer to go with scenario and templates as two different options.
The plan also to design a feast-lab(within feast OR outside) with multiple scenarios to try out like banking/RAG/recommendation etc and hence by using -s OR --scenario we could have directly pull those feat-labs scenarios.
What do you think on this ?
There was a problem hiding this comment.
I guess I think we could put them all in one bc they're lightweight examples
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
There was a problem hiding this comment.
LGTM, just a concern about template vs scenario raised at #5946 (comment) before we merge it.
| ), | ||
| ], | ||
| source=city_summaries_source, | ||
| ttl=timedelta(hours=2), |
There was a problem hiding this comment.
I think for RAG use case TTL could be in days than hours, wdyt ?
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Signed-off-by: Vanshika Vanshika <vvanshik@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
What this PR does / why we need it:
rag_demo.mov
Which issue(s) this PR fixes:
Fixes : #5264