feat: Production ready feast operator with v1 apiversion#5743
Closed
jyejare wants to merge 1 commit intofeast-dev:masterfrom
Closed
feat: Production ready feast operator with v1 apiversion#5743jyejare wants to merge 1 commit intofeast-dev:masterfrom
jyejare wants to merge 1 commit intofeast-dev:masterfrom
Conversation
1498b3d to
dbae106
Compare
Signed-off-by: jyejare <jyejare@redhat.com>
ntkathole
reviewed
Dec 11, 2025
| @@ -0,0 +1,45 @@ | |||
| # This patch adds v1alpha1 as a deprecated version to support migration from previous versions | |||
Member
There was a problem hiding this comment.
@jyejare rather than using rename + patch approach, I think we should use kubebuilder standard approach for API version upgrades, where we keep both v1 and v1aplha1 like:
api/
├── v1/
│ ├── featurestore_types.go (+kubebuilder:storageversion)
│ ├── groupversion_info.go
│ └── zz_generated.deepcopy.go
└── v1alpha1/
├── featurestore_types.go (+kubebuilder:deprecatedversion)
├── groupversion_info.go
└── zz_generated.deepcopy.go
and CRD will look like:
versions:
- name: v1
storage: true # Primary storage version
# Full schema...
- name: v1alpha1
storage: false # Deprecated, not stored
deprecated: true
deprecationWarning: "feast.dev/v1alpha1 FeatureStore is deprecated, use feast.dev/v1 instead"
# Full schema (for validation)
Collaborator
Author
There was a problem hiding this comment.
Yeah, I tried that with latest update but I think there is something wrong with our tests. I am closing this PR as I have messed up the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR now switches the feast operator to API version from
v1alpha1tov1as a production ready operator with no more alpha tag.Which issue(s) this PR fixes:
Closes Jira https://issues.redhat.com/browse/RHOAIENG-39324
Misc