feat: Adding docling to feast as add on#5065
Closed
franciscojavierarceo wants to merge 2 commits intomasterfrom
Closed
feat: Adding docling to feast as add on#5065franciscojavierarceo wants to merge 2 commits intomasterfrom
franciscojavierarceo wants to merge 2 commits intomasterfrom
Conversation
dmartinol
reviewed
Feb 18, 2025
|
|
||
| MILVUS_REQUIRED = ["pymilvus"] | ||
|
|
||
| RAG_REQUIRED = ["docling"] |
Member
Author
There was a problem hiding this comment.
I was going to figure out which version was most appropriate unbounded but this uncovered the broader issue of us having to move to pyproject.toml over the setup.py so we'll have to work on that first.
Member
Author
There was a problem hiding this comment.
And it looks like it's being handled here! #5067
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
016d107 to
927c2cf
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding docling to feast as add on
Which issue(s) this PR fixes:
Misc