feat: Adding support to return additional features from vector retrieval for Milvus db#4971
Merged
franciscojavierarceo merged 5 commits intomasterfrom Jan 28, 2025
Merged
feat: Adding support to return additional features from vector retrieval for Milvus db#4971franciscojavierarceo merged 5 commits intomasterfrom
franciscojavierarceo merged 5 commits intomasterfrom
Conversation
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…val of features from vector similarity search Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Member
Author
|
@HaoXuAI take a look at this PR, I've moved the retrieval implementation to My recommendation is we eventually wipe both of these methods and embed Based on the Milvus documentation and allowing more features to be returned, it makes sense to just incorporate this into |
HaoXuAI
reviewed
Jan 28, 2025
| port: Optional[int] = 19530 | ||
| index_type: Optional[str] = "FLAT" | ||
| metric_type: Optional[str] = "L2" | ||
| metric_type: Optional[str] = "COSINE" |
Collaborator
There was a problem hiding this comment.
Might be better to make it an enum now since there are multiple values
Member
Author
There was a problem hiding this comment.
Yeah sounds good, mind if I do that in a follow up PR?
franciscojavierarceo
pushed a commit
that referenced
this pull request
Feb 4, 2025
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04) ### Bug Fixes * Adding periodic check to fix the sporadic failures of the operator e2e tests. ([#4952](#4952)) ([1d086be](1d086be)) * Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee)) * Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f)) * Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962) * Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85)) * Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d)) * Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939)) * Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9)) * Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52)) * Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703)) * Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3)) * Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102)) * Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68)) * Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55)) ### Features * Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8)) * Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852)) * Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d)) * Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3)) * Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc)) * Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13)) * Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364)) * Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c)) * Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for returning multiple fields when doing vector similarity search with Milvus.
The behavior is now as simple as:
Feature Store Enhancements
retrieve_online_documents_v2method toFeatureStorefor improved document retrieval using embeddings.retrieve_online_documentsto enhance performance and support additional features._retrieve_from_online_store_v2to support the new document retrieval method internally._get_feature_view_vector_field_metadatato fetch metadata for vector fields within aFeatureView.Utility Functions
_get_unique_entities_from_valuesto obtain unique composite entities and their indexes._populate_response_from_feature_data_v2to populate responses with feature data._extract_proto_values_to_dictto handle serialization to string and vector columns.Provider and Online Store Updates
PassthroughProviderandProviderinterfaces to includeretrieve_online_documents_v2.MilvusOnlineStoreandOnlineStorewith support for the new document retrieval method and vector field handling.MilvusOnlineStoreConfigto default toCOSINEmetric type for vector searches.Testing and Example Repositories
test_online_retrieval.pyto include scenarios for the new document retrieval method.Key Modifications
sdk/python/feast/feature_store.py
Fieldimport.retrieve_online_documents_v2method for enhanced document retrieval._retrieve_from_online_storeto handle vector field metadata._retrieve_from_online_store_v2for internal support of the new retrieval method.sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
_get_collectionto handle vector fields.online_write_batchto serialize vector fields and handle entity keys.retrieve_online_documents_v2for Milvus online store.sdk/python/feast/infra/online_stores/online_store.py
retrieve_online_documents_v2method for online document retrieval using embeddings.sdk/python/feast/infra/passthrough_provider.py
retrieve_online_documents_v2method to passthrough provider.sdk/python/feast/infra/provider.py
retrieve_online_documents_v2abstract method to provider interface.sdk/python/feast/utils.py
_get_unique_entities_from_valuesutility function._populate_response_from_feature_data_v2for populating response with feature data._extract_proto_values_to_dictto handle vector columns and serialization.sdk/python/tests/example_repos/example_rag_feature_repo.py
author_identity and updated schema to include vector fields.sdk/python/tests/foo_provider.py
retrieve_online_documents_v2method to the provider.sdk/python/tests/unit/online_store/test_online_retrieval.py
retrieve_online_documents_v2.Which issue(s) this PR fixes:
Another one for #4364
Misc
N/A