Skip to content

add --active-only option to list command#517

Open
kellyselden wants to merge 1 commit intoember-cli-deploy:masterfrom
kellyselden:active-only
Open

add --active-only option to list command#517
kellyselden wants to merge 1 commit intoember-cli-deploy:masterfrom
kellyselden:active-only

Conversation

@kellyselden
Copy link
Contributor

@kellyselden kellyselden commented Mar 30, 2020 •
edited
Loading

We need a way to get the active revision, no matter how old it is. I don't think this is possible now, because you would need to know the amount beforehand. Right now we are working around the issue with:

    'display-revisions': {
      revisions(context) {
        if (process.env.ACTIVE_ONLY) {
          context.revisions = context.revisions.filter(revision => revision.active);
        }

        return context.revisions;
      },
    },

but we would like to upstream this behaviour.

Implementation PR ember-cli-deploy/ember-cli-deploy-display-revisions#23.

@kellyselden kellyselden mentioned this pull request Mar 30, 2020
Open
@lukemelia
Copy link
Contributor

lukemelia commented Mar 30, 2020

@kellyselden I understand the need and this looks fine to me. In order to be merged, this PR should include:

We'll also need to:

  • Resolve unrelated travis build issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kellyselden @lukemelia