[DOC] Updates the signature for configuration properties as functions#491
Open
xcambar wants to merge 1 commit intoember-cli-deploy:masterfrom
Open
[DOC] Updates the signature for configuration properties as functions#491xcambar wants to merge 1 commit intoember-cli-deploy:masterfrom
xcambar wants to merge 1 commit intoember-cli-deploy:masterfrom
Conversation
lukemelia
requested changes
Sep 13, 2017
Contributor
lukemelia
left a comment
There was a problem hiding this comment.
In the code you're referring to: configuredValue.call(this.pluginConfig, this.context, _pluginHelper.call(this)), the first argument to call is what becomes this inside the function, not an argument to the function.
Author
|
Oh no... I missed the So this is what coding during a paternity leave looks like 😂 |
ada497a to
8b84785
Compare
8b84785 to
a598bf8
Compare
Author
|
I've amended to only edit the example. |
Member
|
I'm not sure the proposed change is actually accurate. I need to refamiliarise myself with the code and come back to this with more context though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed & Why
The doc at http://ember-cli-deploy.com/docs/v1.0.x/configuration/#usage states that:
While the code says differently: https://github.com/ember-cli-deploy/ember-cli-deploy-plugin/blob/master/index.js#L68-L70
This PR amends the documentation to reflect the current behaviour.
PR Checklist