Accelerate build context directory file walk#1442
Closed
swiedenfeld wants to merge 5 commits intodocker-java:masterfrom
swiedenfeld:improve-filewalk-performance
Closed
Accelerate build context directory file walk#1442swiedenfeld wants to merge 5 commits intodocker-java:masterfrom swiedenfeld:improve-filewalk-performance
swiedenfeld wants to merge 5 commits intodocker-java:masterfrom
swiedenfeld:improve-filewalk-performance
Conversation
java.nio.file.Path#toUri executes faster compared to java.io.File#toUri
Contributor
Author
|
@bsideup I could use some input on this :) |
Contributor
Author
|
ping (before this goes stale) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Member
|
@swiedenfeld sorry for letting it stale, I will try to find time and have a look at it soon! |
Contributor
Author
|
How can we proceed with this? |
|
I wish this still was a thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the performance issue described in #1409.
#1412 has partially improved performance by memoizing frequently reused ignore patterns.
These commits now improve performance on my Windows 10 machine further by:
Files.walkto efficiently walk the build context directory. It visits files and subdirectories in parallel and filters any items efficiently ignoredWith #1412 and these code changes, build context scans in my unit test setup (see #1412) on my Windows 10 machine now pass in about 6 seconds, while they previously used to take around 27 seconds.