feat: add JAX as Computation Backend #1646
Conversation
1aef069 to
fdcbe92
Compare
samsja
left a comment
There was a problem hiding this comment.
This looks mostly good ! Once we have :
- DocVec working
- Integration test
we will be good to go
a679638 to
83a2b9b
Compare
samsja
left a comment
There was a problem hiding this comment.
looks really good. I added some tiny comments.
We are just missing the interagration test before we merge !
|
btw looking at the CI it seems that you still have place where you load jax without using the helper import and therefore it throw an error |
|
Hey @agaraman0 , would it be possible for you to add a code snippet as an example of the usage of this feature in the PR description. Like this we can add it in future release notes to highlight this awesome feature. |
Sure will do that, I am just looking for some existing example if I can replicate one. |
92e32ec to
6b57436
Compare
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
|
@agaraman0 can you add an equivalent test to the one added for Pytorch and TF in this PR #1696 |
Signed-off-by: agaraman0 <agaraman0@gmail.com>
scott-martens
left a comment
There was a problem hiding this comment.
I think I found all docstrings. A few changes recommended.
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
samsja
left a comment
There was a problem hiding this comment.
Great PR looking forward to merge
Integrating JAX as a computation backend in Docarray similar to Pytorch, Tensorflow, and Numpy
JaxArraytyping implementationJaxArraytyping unit testsJaxCompBackendmethods implementationJaxCompBackendbasic testsDocVecworking