feat: validate file formats in url#1606
Merged
jupyterjazz merged 4 commits intodocarray:feat-file-validationfrom Jun 26, 2023
Merged
feat: validate file formats in url#1606jupyterjazz merged 4 commits intodocarray:feat-file-validationfrom
jupyterjazz merged 4 commits intodocarray:feat-file-validationfrom
Conversation
Signed-off-by: Mohammad Kalim Akram <kalim.akram@jina.ai>
Member
|
I think doing a request to the URL is an overkill and it will make it very slow |
JoanFM
requested changes
May 31, 2023
Signed-off-by: Mohammad Kalim Akram <kalim.akram@jina.ai>
Signed-off-by: Mohammad Kalim Akram <kalim.akram@jina.ai>
JoanFM
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: #1555
Solution:
mime-typeslibrary to detect the mime type from the URL and raise an error if it is not the expected type for that classextra extensionsCAVEAT: Any file without an extension will raise an error, for example, a
wavaudio file with no extension will raise an error.