Fix NonstandardProteinCompoundTest failure#780
Merged
sbliven merged 1 commit intobiojava:bugfixes-4.2from Jun 27, 2018
Merged
Conversation
Uniprot now redirects to https. This fixes the URL, as well as adds code to do the redirect
josemduarte
approved these changes
Jun 27, 2018
Contributor
josemduarte
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me.
We've been hit by the http->https issue a few times in the last months. It is unfortunate that the standard java library by default does not redirect.
Agree on having the new method as a common utility for 5.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uniprot now redirects to https. This fixes the URL, as well as adds code to do the redirect.
I couldn't find any existing code to follow redirects, but it would be useful to apply this to all downloads. The redirect code is a private static function in 4.2. In the 5.0 branch it would make sense to make it a utility method (e.g core/utils/FileDownloadUtils) and apply it everywhere we open HttpUrlConnections.