Changed the SCOP Installation URLs#1077
Merged
josemduarte merged 1 commit intobiojava:masterfrom Jan 25, 2024
Merged
Conversation
…of the URL path to reflect a change in the v2 naming.
josemduarte
requested changes
Jan 8, 2024
Contributor
josemduarte
left a comment
There was a problem hiding this comment.
Thanks for catching this! One comment in the review
| SCOP_DOWNLOAD_ALTERNATE, | ||
| "dir.cla.scop.%s.txt","dir.des.scop.%s.txt", | ||
| "dir.hie.scop.%s.txt","dir.com.scop.%s.txt"); | ||
| } |
Contributor
There was a problem hiding this comment.
The 2 blocks in the if/else look identical. What was the intention of this change?
Member
There was a problem hiding this comment.
One is scope while the other is scop.
Contributor
There was a problem hiding this comment.
Thanks! sorry I missed that.
josemduarte
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was going through the tutorial and was displaying a jmol panel. When I selected Show SCOP Domains for the color on the selection, I received a
FileNotFoundException. A review of the Berkeley site shows that they changed from http to https for the scheme. They also appear to have changed the path portion of the URL in version 2 from 'scop' to 'scope.'All of the unit tests worked before and after this change. I tried to create a unit test to show the failure, fix it, and run the unit test to show that it was fixed, but I couldn't quite follow the path to get to the ScopInstallation code from the Swing application.
To recreate my original error, the following code can be used (derived from the tutorial).