Skip to content

Fix for 1693 bug access to deleted memory in array proxy index #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophe-murphy wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix for 1693 bug access to deleted memory in array proxy index #3600

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c08727
The af_retain_array method is now called for an array for a non-seque…
christophe-murphy Sep 4, 2024
ace0280
Add error checking for retain function
christophe-murphy Sep 5, 2024
21c10f1
Woraround for issue with AF_THROW
christophe-murphy Sep 5, 2024
733edf1
Fix error in indexing over dimensions
christophe-murphy Sep 5, 2024
71ccd1c
Release index arrays when array proxy destructor is called.
christophe-murphy Sep 5, 2024
480d5b2
Added death test for using an array as an index when creating an arra…
christophe-murphy Sep 5, 2024
075f8af
Additional testing of array proxy indexing to ensure fix and to check…
christophe-murphy Mar 4, 2025
968798f
Revert changes.
christophe-murphy Mar 12, 2025
d64ffda
Prevent use of auto for array_proxy assignment
christophe-murphy Mar 12, 2025
9573777
Onlly make array_proxy copy and move constructors private.
christophe-murphy Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added death test for using an array as an index when creating an arra… 
…y proxy
  • Loading branch information
@christophe-murphy
christophe-murphy committed Sep 5, 2024
commit 480d5b2b9d6ceea91f29c62018b0a9ac85a516cd
5 changes: 5 additions & 0 deletions test/array_death_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ using af::seq;
using af::setDevice;
using af::sin;
using af::sort;
using af::span;

template<typename T>
class ArrayDeathTest : public ::testing::Test {};
Expand Down Expand Up @@ -55,6 +56,10 @@ void deathTest() {
array vals, inds;
sort(vals, inds, A);

array cond = constant(1, 3, b8);
auto X = A(span, cond);
array Y = X;

_exit(0);
}

Expand Down