refactor(compiler): clean up pipeline compatibility distinction#67067
Open
crisbeto wants to merge 1 commit intoangular:mainfrom
Open
refactor(compiler): clean up pipeline compatibility distinction#67067crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Removes the switch for compatibility mode from the template pipeline since we never got around to removing it and at this point it causes a bunch of runtime errors.
JeanMeche
reviewed
Feb 14, 2026
| // is not only simpler and faster, but allows more chaining opportunities for other | ||
| // instructions. | ||
| unit.create.push(ir.createPipeOp(expr.target, expr.targetSlot, expr.name)); | ||
| // TODO: We can delete this cast and check once compatibility mode is removed. |
Member
There was a problem hiding this comment.
Can we remove this todo with your change ?
Member
Author
There was a problem hiding this comment.
Doesn't look like it, the op isn't narrowed and I wanted to keep the logic as close the the previous one.
JeanMeche
reviewed
Feb 14, 2026
| @@ -19,7 +19,7 @@ import {literalOrArrayLiteral} from '../conversion'; | |||
| */ | |||
| export function generateProjectionDefs(job: ComponentCompilationJob): void { | |||
| // TODO: Why does TemplateDefinitionBuilder force a shared constant? | |||
Member
There was a problem hiding this comment.
That comment make less sense with the compatibility code removed. Should we reword it ?
Member
Author
There was a problem hiding this comment.
I wanted to keep the context.
JeanMeche
reviewed
Feb 14, 2026
| (e) => { | ||
| if (e instanceof ir.AssignTemporaryExpr && tmps.has(e.xref)) { | ||
| const read = new ir.ReadTemporaryExpr(e.xref); | ||
| // `TemplateDefinitionBuilder` has the (accidental?) behavior of generating assignments of |
Member
There was a problem hiding this comment.
Here too I feel like we should reword the comment if we remove the compatibility
Member
Author
There was a problem hiding this comment.
Same as before, I didn't want to lose the context from the comment.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the switch for compatibility mode from the template pipeline since we never got around to removing it and at this point it causes a bunch of runtime errors.