Add typehints for step func returning types#830
Merged
delatrie merged 1 commit intoallure-framework:masterfrom Mar 27, 2025
Merged
Add typehints for step func returning types#830delatrie merged 1 commit intoallure-framework:masterfrom
delatrie merged 1 commit intoallure-framework:masterfrom
Conversation
|
|
c4a3841 to
c13f359
Compare
c13f359 to
93c015a
Compare
1 task
delatrie
approved these changes
Mar 27, 2025
Contributor
delatrie
left a comment
There was a problem hiding this comment.
Hi, @starod00m ! Thank you for your contribution!
This was referenced Mar 27, 2025
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There are several issues with using pyright as lsp:
allure.stepas a context manager withwith allure.step, pyright returned the errors:Object of type "(...) -> object" cannot be used with "with" because it does not implement __exit__,Object of type "(...) -> object" cannot be used with "with" because it does not implement __enter__ (lsp).allure.stepas a decorator along with@property, pyright returned the error:Argument of type "((self: Self@ClassName) -> SomeReturnType) | object" cannot be assigned to parameter "fget" of type "((Any) -> Any) | None" in function "__init__".Checklist