Skip to content

#1677 fix enum nested in namespace#1679

Open
felixhirt wants to merge 6 commits intoTypeScriptToLua:masterfrom
ita-ch:master
Open

#1677 fix enum nested in namespace#1679
felixhirt wants to merge 6 commits intoTypeScriptToLua:masterfrom
ita-ch:master

Conversation

@felixhirt
Copy link

fixes #1677
Not sure how to do the test correctly, maybe you can improve that or tell me how to

Copy link
Member

@Perryvw Perryvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be way more changes in this branch than just the fix I expected. Please clean this up

D
}
}
`.tap(builder => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just use expectToMatchSnapshot() instead if you want to check the entire content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buggy enum transpilation with namespace

2 participants