You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When. a release of the main package is created via npm version, the subpackage language-extensions will get bumped to the same version. Both will then be published to npm via GitHub Actions
I see that in the tstl package.json we have a dependency on "@typescript-to-lua/language-extensions": "1.0.0". I guess we should also be bumping that version to match the new version.
I am worried that in that case the build order becomes very important. We could not build (npm install) the version bump commit because the packages are not yet available...
I see that in the tstl package.json we have a dependency on "@typescript-to-lua/language-extensions": "1.0.0". I guess we should also be bumping that version to match the new version.
I am worried that in that case the build order becomes very important. We could not build (npm install) the version bump commit because the packages are not yet available...
Good catch. I will think a bit about on how to solve this. AFAIK this dependency is only there to "force" users to download language-extensions alongside TSTL. My initial thoughts and possible solutions:
Remove the dependency and let users install language-extensions manually if needed (not sure if that's good or not)
Change the build order and do something like extension bump -> publish extensions -> tstl bump -> tstl publish. However, this will be difficult with our current setup as we do the bumping locally and releasing via action.
Don't automate just do it manually as you did just now and use the script from the DotA monorepo.
To ensure we don't forgot about releasing an language-extension update in the future we could write a GitHub action that warns us if language-extensions files have been modified without being released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When. a release of the main package is created via
npm version, the subpackagelanguage-extensionswill get bumped to the same version. Both will then be published to npm via GitHub ActionsCloses #1482