fix: add check to see in ownerSymbol parent is the global symbol#1472
Draft
starsprung wants to merge 1 commit intoTypeScriptToLua:masterfrom
Draft
fix: add check to see in ownerSymbol parent is the global symbol#1472starsprung wants to merge 1 commit intoTypeScriptToLua:masterfrom
starsprung wants to merge 1 commit intoTypeScriptToLua:masterfrom
Conversation
when determining when to transform global builtin calls.
Perryvw
reviewed
Aug 6, 2023
| ) { | ||
| const ownerType = context.checker.getTypeAtLocation(calledMethod.expression); | ||
| const ownerSymbol = tryGetStandardLibrarySymbolOfType(context, ownerType); | ||
| if (!ownerSymbol || ownerSymbol.parent) return; |
Member
There was a problem hiding this comment.
Wondering if instead we shouldn't just be removing this ownerSymbol.parent, not really sure if it adds anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check to see in ownerSymbol.parent is the global symbol when determining when to transform global builtin calls.
I'm not sure if this is the appropriate fix, but this change allows calls to
console.logto compile correctly when using the types from @types/node and not using thedomlib. They already work correctly with the type declarations in lib.dom.d.ts, due to a difference in structure: Node's typings wrapconsoleinsideglobal { }, which means it has a parent, whereas console fromlib.dom.d.tsdoesn't.E.g.
Input
tstl output without fix
tstl output with fix