Merged
Conversation
- Updated Lib/collections from CPython v3.14.3 - Preserved RustPython's fallback implementation for defaultdict - Added test for update_reentrant_add_clears_counter - Minor formatting fixes in test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
collectionsfrom CPython v3.14.3.Part of #6839
Changes
Lib/collections/__init__.pyfrom CPython v3.14.3Lib/test/test_collections.pyfrom CPython v3.14.3defaultdict(imports from._defaultdictwhen_collections.defaultdictis not available)test_update_reentrant_add_clears_counterfor Counter classNotes
The main compatibility consideration is that CPython's
collectionsmodule now expectsdefaultdictto be available from the_collectionsC module. Since RustPython doesn't have this implemented yet, we maintain the fallback to the pure Python implementation inLib/collections/_defaultdict.py.