Skip to content

Update datetime to 3.14.3#7084

Open
ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
ShaharNaveh:update-datetime
Open

Update datetime to 3.14.3#7084
ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
ShaharNaveh:update-datetime

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Feb 11, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Style
    • Code formatting improvements to enhance readability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Formatting adjustments to a public function signature in the time stdlib module, including line-breaking of function parameters and consolidation of error return statements. No behavioral or logic changes introduced.

Changes

Cohort / File(s) Summary
Code Formatting
crates/vm/src/stdlib/time.rs		 Function signature parameters redistributed across multiple lines and error return statement consolidated for improved formatting consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Whiskers twitched with glee so bright,
Function lines arranged just right,
No logic changed, just spacing neat,
Formatting dance, a bunny's treat! 🎀

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change in the pull request - updating the datetime module to version 3.14.3, which aligns with the Cargo.toml modifications shown in the summary.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh marked this pull request as ready for review February 11, 2026 12:22
youknowone
youknowone approved these changes Feb 11, 2026
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShaharNaveh Could you please fix the conflict?

@youknowone youknowone enabled auto-merge (squash) February 11, 2026 15:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin update-datetime

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/datetime.py
[x] lib: cpython/Lib/_strptime.py
[x] lib: cpython/Lib/_pydatetime.py
[ ] test: cpython/Lib/test/test_datetime.py
[ ] test: cpython/Lib/test/test_strptime.py

dependencies:

  • datetime

dependent tests: (29 tests)

  • datetime: test_calendar test_email test_enum test_faulthandler test_fstring test_hash test_httpservers test_imaplib test_inspect test_logging test_plistlib test_pydoc test_sqlite3 test_str test_tomllib test_unittest test_xmlrpc test_zoneinfo
    • calendar: test_strftime
      • http.cookiejar: test_http_cookiejar
      • mailbox: test_genericalias test_mailbox
    • email.utils: test_email test_smtplib
      • smtplib: test_smtpnet
    • http.server: test_robotparser test_urllib2_localnet
      • wsgiref.simple_server: test_wsgiref
      • xmlrpc.server: test_docxmlrpc

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone