Skip to content

Move pickletester.py to the correct place#7003

Merged
youknowone merged 4 commits intoRustPython:mainfrom
ShaharNaveh:move-pickletester
Feb 5, 2026
Merged

Move pickletester.py to the correct place#7003
youknowone merged 4 commits intoRustPython:mainfrom
ShaharNaveh:move-pickletester

Conversation

@ShaharNaveh
Copy link
Contributor

#6982 put it under Lib instead of Lib/test by accident

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • Lib/pickletester.py is excluded by !Lib/**
  • Lib/test/pickletester.py is excluded by !Lib/**
  • Lib/test/test_pickle.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/copyreg.py
[x] test: cpython/Lib/test/test_copyreg.py

dependencies:

  • copyreg

dependent tests: (94 tests)

  • copyreg: test_copy test_copyreg test_descr
    • copy: test_ast test_bytes test_codecs test_collections test_coroutines test_csv test_defaultdict test_deque test_dictviews test_email test_enum test_exceptions test_fractions test_functools test_generators test_genericalias test_http_cookies test_inspect test_ipaddress test_itertools test_logging test_memoryview test_opcache test_optparse test_ordered_dict test_platform test_plistlib test_posix test_set test_site test_slice test_statistics test_sysconfig test_tomllib test_types test_typing test_unittest test_uuid test_weakref test_weakset test_xml_dom_minicompat test_xml_etree test_zlib
      • dataclasses: test__colorize test_patma test_pprint test_regrtest test_zoneinfo
      • email.generator: test_email
      • http.cookiejar: test_http_cookiejar
      • http.server: test_httpservers test_robotparser test_urllib2_localnet
      • logging.handlers: test_concurrent_futures
      • mailbox: test_mailbox
      • smtplib: test_smtplib test_smtpnet
      • tarfile: test_shutil test_tarfile
    • pickle: test_array test_asyncio test_builtin test_bz2 test_concurrent_futures test_ctypes test_decimal test_dict test_enumerate test_importlib test_io test_iter test_list test_lzma test_memoryio test_operator test_os test_pathlib test_pickle test_pickletools test_positional_only_arg test_random test_range test_shelve test_socket test_str test_string test_trace test_tuple test_unittest test_zipfile test_zoneinfo

[x] lib: cpython/Lib/pickle.py
[ ] lib: cpython/Lib/_compat_pickle.py
[ ] test: cpython/Lib/test/test_pickle.py (TODO: 28)
[ ] test: cpython/Lib/test/test_picklebuffer.py (TODO: 12)
[ ] test: cpython/Lib/test/test_pickletools.py (TODO: 8)

dependencies:

  • pickle (native: itertools, sys)
    • _compat_pickle
    • _compat_pickle
    • io (native: _io, _thread, errno, sys)
    • codecs, copyreg, functools, struct, types

dependent tests: (69 tests)

  • pickle: test_array test_asyncio test_builtin test_bytes test_bz2 test_codecs test_collections test_concurrent_futures test_coroutines test_csv test_ctypes test_decimal test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enum test_enumerate test_exceptions test_fractions test_functools test_generators test_genericalias test_http_cookies test_importlib test_inspect test_io test_ipaddress test_iter test_itertools test_list test_logging test_lzma test_memoryio test_memoryview test_opcache test_operator test_ordered_dict test_os test_pathlib test_pickle test_pickletools test_platform test_plistlib test_positional_only_arg test_posix test_random test_range test_set test_shelve test_slice test_socket test_statistics test_str test_string test_trace test_tuple test_types test_typing test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_zipfile test_zlib test_zoneinfo
    • logging.handlers: test_concurrent_futures

[ ] lib: cpython/Lib/pickletools.py
[ ] test: cpython/Lib/test/test_pickletools.py (TODO: 8)

dependencies:

  • pickletools (native: sys)
    • io, pickle
    • codecs, re, struct

dependent tests: (1 tests)

  • pickletools: test_pickletools

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowone
Copy link
Member

@ShaharNaveh did you manually do it because update_lib didn't cover it?

@youknowone youknowone merged commit b880c33 into RustPython:main Feb 5, 2026
14 checks passed
@ShaharNaveh
Copy link
Contributor Author

@ShaharNaveh did you manually do it because update_lib didn't cover it?

I did it manually, I didn't even run lib_updater 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants